AnsPress 2.0 – User Profile -> pull request

Question

AnsPress 2.0 – User Profile -> pull request

6.04K viewsJanuary 26, 2015Core

1

ResolveThis Posted January 22, 2015

Hi,

I figured out how to add a custom tab to the user-profile.
I love the extension-pattern that you applied! Thanks!

One issue I found was that the tab-page which I registered with
ap_register_user_page('testtab', __('Test tab', 'ap'), array('AnsPress_User_Page_Test', 'output'));
came first in the menu list. Probably because I called the ap_register_user_page too early.

Anyway, it started me thinking that things might get nasty when multiple plugins want to add a tab -> in which order will they be added?
So I have made some changes to the anspress-master\includes\user.php file in such way that you can now specify an order when registering a tab:
ap_register_user_page('testtab', __('Test tab', 'ap'), 90, array('AnsPress_User_Page_Test', 'output'));

If you agree to it, you can find the changes here: https://www.dropbox.com/s/l2mu2mtfv1kiwwa/user.php?dl=0
I have all the changed sections marked with the //MVRM comment, so you can easily find my changes.

Greetings,

Michiel

3 Answers

score 0 · Answer 1 · 2015-01-26T17:46:12+00:00

0

Rahul Aryan 30.96K Posted January 25, 2015 1 Comment

Here is an example for sorting a menu item

add_filter('ap_user_menu', 'my_user_menu_override');
function my_user_menu_override($menu){
	if(Isset($menu['questions']))
		$menu['questions']['order'] = 1; // add order key here, default order key is 10

	return $menu;
}

ResolveThis commented January 26, 2015

This is working fine 🙂 Thanks

score 0 · Answer 2 · 2015-01-23T18:03:33+00:00

0

ResolveThis Posted January 23, 2015 1 Comment

Hi, I think I succeeded in creating a pull request:
https://github.com/wp3/anspress/pull/243
I don’t know if it was still needed for this change but I just wanted to sort out how to do this so I’m future-proof 😉

Rahul Aryan commented January 23, 2015

Working on it 😉

score 1 · Answer 3 · 2015-01-23T07:03:19+00:00

1

Rahul Aryan 30.96K Posted January 23, 2015 5 Comments

Michiel, Yeh its a good idea. But do not post your code in box.com instead fork our Github anspress and then send pull request.

Janob Tuxsanov commented January 23, 2015

Hi Rahul what about login could you fix ?

Rahul Aryan commented January 23, 2015

will check your issues today.

ResolveThis commented January 23, 2015

Ok, I will look in how to do that. Never created a pull request before 🙂

ResolveThis commented January 23, 2015

Rahul, should I create a GitHub pull request for this change too? Or will you use the file in dropbox for this one time?

ResolveThis commented January 25, 2015

Hi Rahul, I saw your commit on GitHub titled “Added sorting in user menu”, but after downloading the latest version my menu isn’t sorted anymore. Should I set the sorting in another way (not as 3th param of ap_register_user_page)? Thanks

3 Answers

Resources